feat: provides access to the CSS variable created by CSSCustomProprtyBehaviors #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasrice
requested review from
awentzel,
chrisdholt,
EisenbergEffect,
Falkicon and
janechu
as code owners
…https://github.com/microsoft/fast-dna into users/nirice/add-css-variable-access-to-css-behavior
EisenbergEffect
approved these changes
Jun 9, 2020
packages/web-components/fast-foundation/src/custom-properties/behavior.ts
Outdated
Show resolved
Hide resolved
|
@EisenbergEffect looks like a 3.244kb reduction in the fast-components.min.js file |
|
@nicholasrice Nice! |
chrisdholt
approved these changes
Jun 9, 2020
12 tasks
janechu
approved these changes
Jun 10, 2020
nicholasrice
deleted the
users/nirice/add-css-variable-access-to-css-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
varfield to CSSCustomPropertyBehaviors to provide the CSS Custom Property formatted as a CSS variable. This allows the string to be interpolated into stylesheets.Also integrates the interpolation into stylesheets.
Question:
I waffled between
CSSCustomPropertyBehavior.varandCSSCustomPropertyBehavior.css. I want to keep the property concise to benefit from minification processes but wasn't sure which felt more intuitive. If anyone prefers one or the other (or something else) please let me know, I'm not married toCSSCustomPropertyBehavior.var.Motivation & context
Primary changes are in packages/web-components/fast-foundation/src/custom-properties/behavior.ts
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist